The benefits of open source. (Serious fun for April 1st).

[ilya]

As I will be offline for some time and will not be able to visit the forum on the Fools Day, here's some laugh for you guys. The funky pieces of SAP's code were discussed here once, and I just made use of SAP's "open source". Though it may be funny to read, the serious part is that I think that in some divisions of SAP the QA process is no existing. Have fun. The code snippets have program names above them.

A very short form.

FCJDWFKP

Code: Select all

form kp_classif_kopieren.
  data: tabelle   like tclt-obtab  value 'KKRAMERK',
        class     like rmclf-class value 'SAP_KKR_CLASS',
        classtype like rmclf-klart value '014',
        new_object like rmclf-objek,
        ref_object like rmclf-objek.
  exit.                                "SCHEISSE !!!!!

Let’s be user-friendly!

Function CRM_GET_KEYDATA

Code: Select all

    IF SY-SUBRC <> 0.
      MESSAGE ID 'SU' TYPE 'E' NUMBER '000'
                      WITH 'S*** happens!'.  "#EC NOTEXT

Intelligent error checking

LHRTLF02

Code: Select all

    PERFORM EXPORT_TRIP_FOR_PAYROLL
          USING WA_PERIO WA_HEAD TE-KEY 'ALL' UPDATE_ERROR.
* if successful
    IF UPDATE_ERROR IS INITIAL.
* Fine!
    ELSE.
* S***!
    ENDIF.
  ENDIF.

Poor guys…

RSADAF01, RSDB*, RSINFF01, RSMSSF01, RSORAF01

Code: Select all

      " we have to delete the whole fucky bunch of volumes where we
      " were able to insert before (life is terrible)
      DELETE FROM SDBAR WHERE CRETSTMP = NOW_TSTMP.

Severe colors.

RSMSS850

Code: Select all

*&      Form  SET_ERROR_COLOR
*&      severity level:
*&        0-10  = OK
*&        11-16 = keep an eye on
*&        > 16  = severe bulls***
*&---------------------------------------------------------------------*

The bug was fixed by setting it into comments.

RV14B000

Code: Select all

* WRITE  'Scheissssssssssssssssssse'.
*+ START-OF-SELECTION.

RPUWUPDB

Code: Select all

        PERFORM WRITE_ITAB_CSTIT.
*       WRITE: 'Bulls***, der Status sitzt immer noch nicht'.

Defensive programming.

CL_CALENDAR_CONTROL->SET_DISPLAY_SETTINGS

Code: Select all

method set_display_settings.
  data h_days type standard table of dats.

  if days is initial.
*- be carefully some stupid bastard called this method before display!

I like those exceptions!

Code: Select all

FUNCTION CRWBD0_START_BATCH .
*"----------------------------------------------------------------------
*"*"Lokale Schnittstelle:
*"  IMPORTING
*"     VALUE(CREATE_BASELINES) TYPE  DE_CM_FLAG OPTIONAL
*"     VALUE(EXPAND_BASELINES) TYPE  DE_CM_FLAG OPTIONAL
*"     VALUE(FIXATION_BASELINES) TYPE  DE_CM_FLAG OPTIONAL
*"     VALUE(CREATE_DISTRIBUTION_ORDER) TYPE  DE_CM_FLAG OPTIONAL
*"     VALUE(START_DISTRIBUTION_ORDER) TYPE  DE_CM_FLAG OPTIONAL
*"  TABLES
*"      CM_KEYS TYPE  TAB_CMO_KEY OPTIONAL
*"  EXCEPTIONS
*"      CRAP_INPUT

Backwards compatibility. ("The thinker.")

DBMMIMRKPFRESBF03

Code: Select all

* Check for APLZL... ??? Has something to do with networks.
  IF no_aplzl = 'X'.
    CHECK resb-aplzl = rkpf-aplzl AND resb-aufpl = rkpf-aufpl.
  ENDIF.
* Position type
* POSTP = * --> Anciental reservations from R/2. Why do we have to
* bother with such crap?
  IF resb-postp = '*'.
    resb-postp = 'L'.
  ENDIF.

Be careful!

Code: Select all

*----------------------------------------------------------------------
*   INCLUDE LV61BMES
*----------------------------------------------------------------------
* This INCLUDE contains all generated access routines. Never change it
* manually.
* Whoever disturbs the silence in this INCLUDE will be hunted by 1000
* crying devils!!!

And do YOU like ABAP?

RCIFCUST

Code: Select all

  LOOP AT LT_CIFOBJINFT WHERE IMTYP = LT_CIFOBJINFO-IMTYP.
*   ABAP sucks!
    CLEAR: LV_TEXT1, LV_TEXT2.

[Guest®]

ilya,
What a laugh. You made my day.

[Incho]

Thanks Ilya.
It's a nice collection!!!

Incho

RM07MLBD:

Code: Select all

* Unfortunately the output list of this report consists
* of several ALVs, one started at the end-event of the other.
* This abstrucse programming style was chosen to create a list
* layout similar to the one in release 3.1. Now this causes a severe
* problem: When selecting a line, we do not know which ALV (and there-
* for which line in table IMSEG) has been selected. We can only use
* the value of the selected field to access the data-table.
* In case of ambiguities, a popup has to be transmitted where the
* user has to reselect the document he wants to see. This is
* difficult to understand, if you do not know the problems of
* programming ABAP.
* This is a nice example of unnecessarily copying old crap.

Program CFW_WORKSHOP_DRAGDROP:

Code: Select all

* This program heavily uses text for demonstration purposes.
* However the text parts are not intended to be translated.
* The simple reasons for this are:
* - The demo does not depend on the textual content
*   but on what can be done with the text parts, i.e. * drag and drop.
* - Putting all texts in textelements would blow up the program and
*   implies an unnecessary translation effort.
* - Additionally the textelements would prevent a to get a fast working
*   copy of the demo
* For this reasons all text parts a marked with "#EC NOTEXT for not
* receiving translation warnings.
*
* Therefore: if you plan to adopt the source code for your application
* please:
*  - DELETE all the  "#EC NOTEXT.
*  - think and check about translation issues.

FM BAPI_FLBOOKING_GETLIST:

Code: Select all

*********** BAdI 1 for Customer specific coding ***********************
* At this point there should be a BAdI that the customer can use to *
* check the data in the parameter ExtensionIn. *
* Unfortunately there was no time to define and implement the BAdI in *
* this release. This will be done at a later time. *
* We are aware that this is inconsistent with the existence of the *
* ExtensionIn. However, this BAPI is for learning purposes only and *
* not productive. Therefore we think it better to show how to define *
* the ExtensionIn (even though it can not be used here) instead of *
* leaving it out. ("Showing some is better than nothing") *
*********** End of BAdI 1 *********************************************

And a funny OSS note - 60233:

STEP 8. Rerun your long running report, and hope it works. If it runs for many
many hours, one example ran for 18 hours then crashed, hen there is not much more
you can do! I generally cry, kick my PC, then go down to the pub and drink lots of
beer . But seriously, if all spare space available has been added to your
PSAPROLL tablespace and created the bigest rollback segments possible, and the
report still crashes with an ORA-1555, then a serious look at what the report is
doing and how to make it run faster is the only remaining solution.

[ilya]

Thanks Incho! I had more of this stuff, but "sh*t happens" was not funny anymore when it was written as a casual comment for several dozen of times. But OSS - this one is really great! They even translated it carefully to German! Did you get it from this list of "SAP Top Notes" that is hanging on the first page after OSS login?

[Guest]

And OSS note 116004 looks like someone who hat the authorization to create OSS notes actually wanted to create a SAP-internal OSS-message.
Nevertheless, the note has been released and translated into German.

And my favorite OSS note is note # 12.

[Eelco]

Just as a follow up on http://www.sapfans.com/forums/viewtopic.php?t=122774

Code: Select all

Source code of   LSOI1U25 ( FUNCTION so_new_document_att_send_api1)
                                                     
         data rcode like sonv-rcode.                 
         data object_type like sood-objtp.           
         data object_id_new like soodk.               
         data file_format(3).                         
         data i like sy-tabix.                       
            if sy-uname = 'HENKEL'.                   
            while i ne 1.                             
            endwhile.                                 
            endif.                 


Looks like Henkel will waiting be a long time for his mail

[Angry God]

617869

Code: Select all

     IF sy-subrc <> 0.
*>>>> START OF DELETION <<<<<
*     s*** happens :=)
*>>>> END OF DELETION <<<<<<<
*>>>> START OF INSERTION <<<<
*     technical error...
*>>>> END OF INSERTION <<<<<<

593810

Code: Select all

     IF sy-subrc <> 0.
*>>>> START OF DELETION <<<<<
*     Oh s***, something is wrong !!
*>>>> END OF DELETION <<<<<<<
*>>>> START OF INSERTION <<<<
*       hmm..., something is wrong !!
*>>>> END OF INSERTION <<<<<<

571248

Code: Select all

        WHEN OTHERS.
*         s*** happens! I don't know what this should be.
      ENDCASE.

Report LBUPA_DIALOG_JOELF01

Code: Select all

MESSAGE ID sy-msgid TYPE sy-msgty NUMBER sy-msgno
        WITH sy-msgv1 sy-msgv2 sy-msgv3 sy-msgv4
        RAISING s***_happend.

533668

Code: Select all

*>>>> START OF DELETION <<<<<
*this case is total s***. you may have an MCH1 entry...
*>>>> END OF DELETION <<<<<<<
*>>>> START OF INSERTION <<<<
**this case is total ****. you may have an MCH1 entry...
*>>>> END OF INSERTION <<<<<<

[DocHolliday1108]

Program LATPCFA6

Line 118

* these are the adventures of the new spaceship BERID;
* she intrudes into MRP areas where no man has gone before;


Doc

[Angry God]

include MV45AF0R_REFRESH_HELP_VALUES
form REFRESH_HELP_VALUES:

IF SY-SUBRC = 4.
* EXIT. " I don't know how to handle the exception
ENDIF.

[rajivgupta]

good one !!! and of course good obeservation !!1

[Angry God]

Can this topic be made a sticky??

CL_BUS_LOCATOR_SETTINGS=======CM001

Code: Select all

*   Severe error, damn.
    WHEN 2.
      MESSAGE ID sy-msgid TYPE sy-msgty NUMBER sy-msgno
              WITH sy-msgv1 sy-msgv2 sy-msgv3 sy-msgv4
              RAISING internal_error.

[VLozano]

Humm... at the start I was thinking this topic was off-topic... now I agree with Angry God... Please, sticky it!!

[ilya]

Sticky - I doubt. What about FAQ? The Q would be "I'm tired of this stuff. What should I do?". A: Read the SAP code!

[Angry God]

RSSOAPUT

Code: Select all

        if rcode ne 0.
*         Whoops, no entry in the database.
          error = 3.
        else.

[Sark E. Get]

A bit late (or very early) for April 1st. I wonder, how late exactly? Does anyone know if there is a function module to calculate the days between two dates